mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
Date Fri, 10 Jul 2020 02:29:26 GMT


> On July 10, 2020, 8:26 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 1108-1112 (original), 1108-1116 (patched)
> > <https://reviews.apache.org/r/72661/diff/1/?file=2235533#file2235533line1108>
> >
> >     Is it true that only one of these must be set? Should we note that?

Yes! I have added a comment to note that.


> On July 10, 2020, 8:26 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 1118-1120 (patched)
> > <https://reviews.apache.org/r/72661/diff/1/?file=2235533#file2235533line1118>
> >
> >     Perhaps:
> >     
> >     "The root directory of all the target paths managed by the CSI plugin. Each
volume will be published by the CSI plugin at a sub-directory under this path."

Agree!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221172
-----------------------------------------------------------


On July 8, 2020, 4:59 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
> 
> (Updated July 8, 2020, 4:59 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10148
>     https://issues.apache.org/jira/browse/MESOS-10148
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129 
>   include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5 
> 
> 
> Diff: https://reviews.apache.org/r/72661/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message