mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72660: Added CSI volume type into the `Volume` protobuf message.
Date Thu, 09 Jul 2020 15:13:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72660/
-----------------------------------------------------------

(Updated July 9, 2020, 11:13 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
-------

Removed `types.proto`.


Bugs: MESOS-10147
    https://issues.apache.org/jira/browse/MESOS-10147


Repository: mesos


Description (updated)
-------

Also removed the `types.proto` file which has `VolumeCapability`
defined as well so that we will have a single place (`mesos.proto`)
to define this protobuf message.


Diffs (updated)
-----

  include/mesos/csi/types.hpp df9df385d56c54885318881e952056e6747e1f8d 
  include/mesos/csi/types.proto 3e1ac4b623a84043e0a05bade0fb80205b1d266c 
  include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129 
  include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 8b6da3a2dabc1d904ec58c8041097b7378233aff

  include/mesos/type_utils.hpp 98a29957f85c46535c354244fd249905f25f45c2 
  include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5 
  src/CMakeLists.txt bcb5128f0e61af0d541502e4ed833da0487b7792 
  src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49 
  src/common/type_utils.cpp 5bf7113f8f717524f57404bcddfca3d938800d05 
  src/csi/state.proto 96ba420ea1c355705a44c84f5299f3ccaec97470 
  src/csi/types.cpp cb5ee8fbf8aa248a2394ad4c32f90af57f6507c8 
  src/csi/v0_utils.hpp 468b41626f3bbe6c780ae97db169c79bfb79e0f3 
  src/csi/v0_utils.cpp 248e417f0215dcecf5fd484274fa7cb46338fbb2 
  src/csi/v0_volume_manager.hpp 9d572e727dedbc4b4f43a43f8f269e9d6257f234 
  src/csi/v0_volume_manager.cpp 4b056e7525a5dde62e5e74bf592bfa37cccf7736 
  src/csi/v0_volume_manager_process.hpp 50148ff81c2591f8c3e990f019c31addcf3150c0 
  src/csi/v1_utils.hpp 11a64d7a8e1861a4dafffd8a0935894edd8f27dc 
  src/csi/v1_utils.cpp e74138ba6ba7be147d74a4c0350135fd6e203544 
  src/csi/v1_volume_manager.hpp ba984a9a0ff7ef01f3ebeabc33fa42c29694e654 
  src/csi/v1_volume_manager.cpp 9e449472252fd03940abaedcc5bd102fdaa63b47 
  src/csi/v1_volume_manager_process.hpp a03e291e114741502c7703b4cd94751e9530c478 
  src/csi/volume_manager.hpp 0aa6337bde91767095f4c35675483bbb6a683357 
  src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2 
  src/resource_provider/state.proto e19d609ec38f5f0d2f457ec872257487c01be182 
  src/tests/csi_utils_tests.cpp 5ebd0e1091c0dcfa54628b74c27d3fc2b20799bf 
  src/tests/disk_profile_adaptor_tests.cpp 2809847566d79da9ce85f0b3f1979d327a8936c0 


Diff: https://reviews.apache.org/r/72660/diff/3/

Changes: https://reviews.apache.org/r/72660/diff/2-3/


Testing
-------


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message