mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72654: Added documentation for the TEARDOWN master call.
Date Wed, 08 Jul 2020 10:15:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72654/#review221152
-----------------------------------------------------------




docs/operator-http-api.md
Lines 2750 (patched)
<https://reviews.apache.org/r/72654/#comment309939>

    Maybe add a note that currently TEARDOWN provides no guarantee that after master failover
Mesos will not treat the framework as running?
    
    (I mean the case we discussed recently: if a previously unreachable agent with some of
the framework's tasks manages to register with a new master, the framework will become know
as running - and not as torn down - to the new master).



docs/operator-http-api.md
Lines 2776 (patched)
<https://reviews.apache.org/r/72654/#comment309940>

    What does this line refer to?



docs/operator-http-api.md
Lines 2777 (patched)
<https://reviews.apache.org/r/72654/#comment309941>

    Maybe s/is not valid/does not correspond to a running framework/? 
    (would be good to make clear that double teardown / teardown of a completed framewor will
result in `400`)



docs/operator-http-api.md
Lines 2779 (patched)
<https://reviews.apache.org/r/72654/#comment309942>

    Hmm... is it clear enough that this line refers to declined authorization (and not some
kind of retryable authorization failure)?


- Andrei Sekretenko


On July 7, 2020, 7:50 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72654/
> -----------------------------------------------------------
> 
> (Updated July 7, 2020, 7:50 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Andrei Sekretenko, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for the TEARDOWN master call.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 585e94c2edfcd844eaee87b904f303031f1c6012 
> 
> 
> Diff: https://reviews.apache.org/r/72654/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message