mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Date Wed, 01 Jul 2020 11:40:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72547/
-----------------------------------------------------------

(Updated July 1, 2020, 11:40 a.m.)


Review request for mesos, Andrei Budnik, Benjamin Mahler, Greg Mann, Qian Zhang, and Vinod
Kone.


Changes
-------

Removed the intermediate dependencies (PROTOC_TARGET/GRPC_CPP_PLUGIN_TARGET)


Bugs: MESOS-10135
    https://issues.apache.org/jira/browse/MESOS-10135


Repository: mesos


Description
-------

This patch adds dependencies onto `protoc` and the GRPC C++ plugin
to the `*pb.h` / `*.pb.cc` targets.


Diffs (updated)
-----

  src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49 


Diff: https://reviews.apache.org/r/72547/diff/4/

Changes: https://reviews.apache.org/r/72547/diff/3-4/


Testing
-------

Built in internal CI on several different platforms.


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message