mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dong Zhu <d...@d2iq.com>
Subject Re: Review Request 72600: Remove credential text format support.
Date Tue, 23 Jun 2020 03:40:41 GMT


> On June 19, 2020, 6:28 p.m., Benjamin Mahler wrote:
> > Can you mark down this breaking change in the changelog?
> > 
> > I think we'll need to send an email to users about this change, since it may break
some users.

You mean this file https://github.com/apache/mesos/blob/master/CHANGELOG ? And which section
should it be added to ?


> On June 19, 2020, 6:28 p.m., Benjamin Mahler wrote:
> > src/credentials/credentials.hpp
> > Line 67 (original), 65 (patched)
> > <https://reviews.apache.org/r/72600/diff/1/?file=2234791#file2234791line67>
> >
> >     Can you re-work the logic here so that errors are handled first and the error
messages from the Trys are included?

Hi Ben,

Sure. I have updated the patch per your suggestion.


- Dong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221037
-----------------------------------------------------------


On June 23, 2020, 3:40 a.m., Dong Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72600/
> -----------------------------------------------------------
> 
> (Updated June 23, 2020, 3:40 a.m.)
> 
> 
> Review request for mesos, Adam Berry, Benjamin Bannier, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since text format for credential is no longer supported, remove it.
> 
> 
> Diffs
> -----
> 
>   src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
> 
> 
> Diff: https://reviews.apache.org/r/72600/diff/2/
> 
> 
> Testing
> -------
> 
> Manually tested
> make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message