mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72600: Remove credential text format support.
Date Fri, 19 Jun 2020 18:28:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221037
-----------------------------------------------------------



Can you mark down this breaking change in the changelog?

I think we'll need to send an email to users about this change, since it may break some users.


src/credentials/credentials.hpp
Line 67 (original), 65 (patched)
<https://reviews.apache.org/r/72600/#comment309816>

    Can you re-work the logic here so that errors are handled first and the error messages
from the Trys are included?


- Benjamin Mahler


On June 19, 2020, 10:29 a.m., Dong Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72600/
> -----------------------------------------------------------
> 
> (Updated June 19, 2020, 10:29 a.m.)
> 
> 
> Review request for mesos, Adam Berry, Benjamin Bannier, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since text format for credential is no longer supported, remove it.
> 
> 
> Diffs
> -----
> 
>   src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
> 
> 
> Diff: https://reviews.apache.org/r/72600/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested
> make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message