mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72596: Added support of `null` values for syscall `args` in Seccomp.
Date Wed, 17 Jun 2020 01:56:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72596/#review221019
-----------------------------------------------------------


Fix it, then Ship it!





src/linux/seccomp/seccomp_parser.cpp
Line 447 (original), 449 (patched)
<https://reviews.apache.org/r/72596/#comment309796>

    I think it should be `args` rather than `names`, right?


- Qian Zhang


On June 16, 2020, 5:21 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72596/
> -----------------------------------------------------------
> 
> (Updated June 16, 2020, 5:21 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds support for `null` values of syscall arguments.
> If the value is `null`, then syscall arguments are ignored.
> 
> 
> Diffs
> -----
> 
>   src/linux/seccomp/seccomp_parser.cpp 3dcfcd6d3c416ef00fa8716bb4cf6cff89831697 
> 
> 
> Diff: https://reviews.apache.org/r/72596/diff/1/
> 
> 
> Testing
> -------
> 
> 1. `sudo make check`
> 2. launched the agent with the latest Seccomp profile
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message