mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72575: Added URI to failure messages in URI fetcher plugins.
Date Mon, 08 Jun 2020 18:39:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72575/#review220973
-----------------------------------------------------------




src/uri/fetchers/curl.cpp
Line 156 (original), 156 (patched)
<https://reviews.apache.org/r/72575/#comment309725>

    Nit: could you do an explicit capture here instead of implicit?


- Greg Mann


On June 8, 2020, 12:49 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72575/
> -----------------------------------------------------------
> 
> (Updated June 8, 2020, 12:49 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Qian Zhang.
> 
> 
> Bugs: MESOS-7485
>     https://issues.apache.org/jira/browse/MESOS-7485
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added URI to failure messages in URI fetcher plugins.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/curl.cpp 1796620cb5d1245eb2ac448b6cb821b8d57c4b49 
>   src/uri/fetchers/docker.cpp 09feb689b225f87ae08b2050f21380e289b3e897 
> 
> 
> Diff: https://reviews.apache.org/r/72575/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message