From reviews-return-91778-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 30 18:51:03 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 621D019DBE for ; Thu, 30 Apr 2020 18:51:03 +0000 (UTC) Received: (qmail 83931 invoked by uid 500); 30 Apr 2020 18:51:02 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 83912 invoked by uid 500); 30 Apr 2020 18:51:02 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83887 invoked by uid 99); 30 Apr 2020 18:51:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Apr 2020 18:51:02 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E1EC2E0289; Thu, 30 Apr 2020 18:51:01 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id AEC82C40109; Thu, 30 Apr 2020 18:51:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5477390315543438496==" MIME-Version: 1.0 Subject: Re: Review Request 72304: Moved documentation into os/shell.hpp interface. From: Greg Mann To: Andrei Sekretenko , Greg Mann Cc: Benjamin Mahler , mesos Date: Thu, 30 Apr 2020 18:51:01 -0000 Message-ID: <20200430185101.14073.61426@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72304/ X-Sender: Greg Mann X-ReviewBoard-ShipIt: 1 References: <20200401235524.58506.87456@reviews-vm2.apache.org> In-Reply-To: <20200401235524.58506.87456@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============5477390315543438496== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72304/#review220568 ----------------------------------------------------------- Ship it! Ship It! - Greg Mann On April 1, 2020, 11:55 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72304/ > ----------------------------------------------------------- > > (Updated April 1, 2020, 11:55 p.m.) > > > Review request for mesos, Andrei Sekretenko and Greg Mann. > > > Repository: mesos > > > Description > ------- > > The os/shell.hpp wrapper provides a single place to read the interface > and documentation for both POSIX and Windows, this makes it easier > for us to document the interface and OS differences that a caller > needs to know about in one place. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/shell.hpp 2cc4e2cd206e9d91541dfad1e7eb2da213188420 > 3rdparty/stout/include/stout/os/shell.hpp 33cc8a672a8edc46478ad57a01a20ed90acf40ad > 3rdparty/stout/include/stout/os/windows/shell.hpp 2f76bbaac9032906c544010c55cdcbe3d7b03d23 > > > Diff: https://reviews.apache.org/r/72304/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > > --===============5477390315543438496==--