From reviews-return-91762-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Apr 29 12:18:45 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id A2A081975F for ; Wed, 29 Apr 2020 12:18:45 +0000 (UTC) Received: (qmail 91464 invoked by uid 500); 29 Apr 2020 12:18:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 91443 invoked by uid 500); 29 Apr 2020 12:18:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 91426 invoked by uid 99); 29 Apr 2020 12:18:44 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2020 12:18:44 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 30641E0289; Wed, 29 Apr 2020 12:18:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 819ECC4008A; Wed, 29 Apr 2020 12:18:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0137031817732354981==" MIME-Version: 1.0 Subject: Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits. From: Qian Zhang To: Andrei Budnik , Greg Mann Cc: Mesos Reviewbot , Qian Zhang , mesos Date: Wed, 29 Apr 2020 12:18:42 -0000 Message-ID: <20200429121842.17390.44947@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72402/ X-Sender: Qian Zhang References: <20200425105515.57655.52082@reviews-vm2.apache.org> In-Reply-To: <20200425105515.57655.52082@reviews-vm2.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============0137031817732354981== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72402/ ----------------------------------------------------------- (Updated April 29, 2020, 8:18 p.m.) Review request for mesos, Andrei Budnik and Greg Mann. Changes ------- Addressed review comments. Bugs: MESOS-10117 https://issues.apache.org/jira/browse/MESOS-10117 Repository: mesos Description ------- Updated Docker containerizer's `usage()` to support resource limits. Diffs (updated) ----- src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 src/tests/containerizer/docker_containerizer_tests.cpp b069f518d51225c39f0cd5126c02fa08674566ab Diff: https://reviews.apache.org/r/72402/diff/6/ Changes: https://reviews.apache.org/r/72402/diff/5-6/ Testing ------- sudo make check Thanks, Qian Zhang --===============0137031817732354981==--