From reviews-return-91745-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 28 20:37:29 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 2CEB519989 for ; Tue, 28 Apr 2020 20:37:28 +0000 (UTC) Received: (qmail 81682 invoked by uid 500); 28 Apr 2020 20:37:27 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 81668 invoked by uid 500); 28 Apr 2020 20:37:27 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 81648 invoked by uid 99); 28 Apr 2020 20:37:27 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Apr 2020 20:37:27 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7B595E00B7; Tue, 28 Apr 2020 20:37:26 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 475B0C4008A; Tue, 28 Apr 2020 20:37:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6185975188184608338==" MIME-Version: 1.0 Subject: Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits. From: Greg Mann To: Andrei Budnik , Greg Mann Cc: Qian Zhang , mesos Date: Tue, 28 Apr 2020 20:37:26 -0000 Message-ID: <20200428203726.19515.44577@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72402/ X-Sender: Greg Mann References: <20200425105515.57655.52082@reviews-vm2.apache.org> In-Reply-To: <20200425105515.57655.52082@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============6185975188184608338== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72402/#review220530 ----------------------------------------------------------- src/slave/containerizer/docker.cpp Lines 2077-2099 (patched) What do you think about moving this logic into the conditionals below where `totalCPUs` and `totalMem` are used? src/slave/containerizer/docker.cpp Lines 2164-2167 (patched) Should we have an `#else` case here which does not check the value of `cgroups_enable_cfs`? src/slave/containerizer/docker.cpp Line 2095 (original), 2179-2181 (patched) Why don't we set the soft limit in this case? - Greg Mann On April 25, 2020, 10:55 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72402/ > ----------------------------------------------------------- > > (Updated April 25, 2020, 10:55 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10117 > https://issues.apache.org/jira/browse/MESOS-10117 > > > Repository: mesos > > > Description > ------- > > Updated Docker containerizer's `usage()` to support resource limits. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 > src/tests/containerizer/docker_containerizer_tests.cpp b069f518d51225c39f0cd5126c02fa08674566ab > > > Diff: https://reviews.apache.org/r/72402/diff/5/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > > --===============6185975188184608338==--