From reviews-return-91712-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Apr 25 10:55:20 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 89D9E19D58 for ; Sat, 25 Apr 2020 10:55:20 +0000 (UTC) Received: (qmail 36474 invoked by uid 500); 25 Apr 2020 10:55:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 36454 invoked by uid 500); 25 Apr 2020 10:55:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36438 invoked by uid 99); 25 Apr 2020 10:55:19 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Apr 2020 10:55:19 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DA2E8E0339; Sat, 25 Apr 2020 10:55:18 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C74F1C4014B; Sat, 25 Apr 2020 10:55:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4946895164697184635==" MIME-Version: 1.0 Subject: Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits. From: Qian Zhang To: Andrei Budnik , Greg Mann Cc: Qian Zhang , mesos Date: Sat, 25 Apr 2020 10:55:18 -0000 Message-ID: <20200425105518.57656.70287@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72399/ X-Sender: Qian Zhang References: <20200424122533.60146.1640@reviews-vm2.apache.org> In-Reply-To: <20200424122533.60146.1640@reviews-vm2.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============4946895164697184635== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72399/ ----------------------------------------------------------- (Updated April 25, 2020, 6:55 p.m.) Review request for mesos, Andrei Budnik and Greg Mann. Changes ------- Set container's hard CPU limit to host total CPU numbers if the CPU limit specified by framework is infinity. Bugs: MESOS-10117 https://issues.apache.org/jira/browse/MESOS-10117 Repository: mesos Description ------- Updated UCR's `usage()` method to support resource limits. Diffs (updated) ----- src/slave/containerizer/mesos/containerizer.hpp 2ea033aa1869f07644b10c036fda1698d08aa89b src/slave/containerizer/mesos/containerizer.cpp 6aa4f3fe0940575aeea6a63cdb1ca3c77cd2359b src/tests/slave_recovery_tests.cpp 0efd3a6ac09ad06d9365b7bb2295157b5175e6b8 src/tests/slave_tests.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db Diff: https://reviews.apache.org/r/72399/diff/5/ Changes: https://reviews.apache.org/r/72399/diff/4-5/ Testing ------- Thanks, Qian Zhang --===============4946895164697184635==--