From reviews-return-91659-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 21 17:43:42 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id BD718192CD for ; Tue, 21 Apr 2020 17:43:41 +0000 (UTC) Received: (qmail 22346 invoked by uid 500); 21 Apr 2020 17:43:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22326 invoked by uid 500); 21 Apr 2020 17:43:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22302 invoked by uid 99); 21 Apr 2020 17:43:40 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2020 17:43:40 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E1B07E0115; Tue, 21 Apr 2020 17:43:39 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id CD860C4024C; Tue, 21 Apr 2020 17:43:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3190523523975742753==" MIME-Version: 1.0 Subject: Review Request 72406: Fixed a bug where the openssl socket can block forever. From: Benjamin Mahler To: Greg Mann Cc: Benjamin Mahler , mesos Date: Tue, 21 Apr 2020 17:43:39 -0000 Message-ID: <20200421174339.36680.80438@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72406/ X-Sender: Benjamin Mahler Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============3190523523975742753== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72406/ ----------------------------------------------------------- Review request for mesos and Greg Mann. Bugs: MESOS-10124 https://issues.apache.org/jira/browse/MESOS-10124 Repository: mesos Description ------- Using the zero byte read trick against io::read is problematic since io::read aims to provide consistent behavior across POSIX and Windows by returning immediately. Now that io::poll for reads is implemented, we can fix this by removing the Windows specialization and just using io::poll. Diffs ----- 3rdparty/libprocess/src/ssl/openssl_socket.cpp 3f4dab6b92f202ee89cc2e06db997c41e4c6ca00 Diff: https://reviews.apache.org/r/72406/diff/1/ Testing ------- make check and started running it through internal CI Thanks, Benjamin Mahler --===============3190523523975742753==--