From reviews-return-91657-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 21 17:43:37 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 03695192CB for ; Tue, 21 Apr 2020 17:43:36 +0000 (UTC) Received: (qmail 22074 invoked by uid 500); 21 Apr 2020 17:43:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22060 invoked by uid 500); 21 Apr 2020 17:43:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22036 invoked by uid 99); 21 Apr 2020 17:43:36 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2020 17:43:36 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A1B8DE0115; Tue, 21 Apr 2020 17:43:35 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8D6F4C4024C; Tue, 21 Apr 2020 17:43:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1820853229768889937==" MIME-Version: 1.0 Subject: Review Request 72405: Added support for read readiness polling on Windows. From: Benjamin Mahler To: Andrei Sekretenko , Greg Mann Cc: Benjamin Mahler , mesos Date: Tue, 21 Apr 2020 17:43:35 -0000 Message-ID: <20200421174335.36681.86343@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72405/ X-Sender: Benjamin Mahler Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============1820853229768889937== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72405/ ----------------------------------------------------------- Review request for mesos, Andrei Sekretenko and Greg Mann. Repository: mesos Description ------- This uses the zero byte read trick on Windows in order to implement read readiness polling on Windows. The documentation for io::read has also been updated to explain how zero byte reads are treated consistently across POSIX and Windows. Write readiness polling is left unimplemented since it's less straightforward. A good explanation of the Windows landscape for polling is here: https://github.com/python-trio/trio/issues/52 A library providing an epoll like interface on Windows can be found here: https://github.com/piscisaureus/wepoll Diffs ----- 3rdparty/libprocess/include/process/io.hpp 468b3626e0121bc380ea592f485f3cfe9796d0fe 3rdparty/libprocess/src/io.cpp 7288d5fa1c79f5d19a9369e6431dc98d92307868 3rdparty/libprocess/src/io_internal.hpp 09bfa9a386a3eb89a987eea18e08144a50aaf5c7 3rdparty/libprocess/src/windows/io.cpp 90e780d4d3eae7af71ee39ff99105147992e968d Diff: https://reviews.apache.org/r/72405/diff/1/ Testing ------- Added a test in subsequent patch. Thanks, Benjamin Mahler --===============1820853229768889937==--