From reviews-return-91528-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 3 02:16:39 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 361F6190B7 for ; Fri, 3 Apr 2020 02:16:39 +0000 (UTC) Received: (qmail 34830 invoked by uid 500); 3 Apr 2020 02:16:38 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 34787 invoked by uid 500); 3 Apr 2020 02:16:38 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34767 invoked by uid 99); 3 Apr 2020 02:16:38 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2020 02:16:38 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 988DBE069E; Fri, 3 Apr 2020 02:16:37 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 66E76C40224; Fri, 3 Apr 2020 02:16:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2938695116544504753==" MIME-Version: 1.0 Subject: Re: Review Request 72297: Added agent-side validation for resource limits. From: Greg Mann To: Qian Zhang , Benjamin Mahler Cc: Mesos Reviewbot , Greg Mann , mesos Date: Fri, 03 Apr 2020 02:16:37 -0000 Message-ID: <20200403021637.47045.2382@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72297/ X-Sender: Greg Mann References: <20200402171712.47045.2129@reviews-vm2.apache.org> In-Reply-To: <20200402171712.47045.2129@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============2938695116544504753== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72297/ ----------------------------------------------------------- (Updated April 3, 2020, 2:16 a.m.) Review request for mesos, Benjamin Mahler and Qian Zhang. Repository: mesos Description ------- This prevents tasks from being launched on agents which would not be capable of enforcing the specified limits. Diffs (updated) ----- src/slave/slave.hpp d7e65e0538caa850b1a5bae837e7c06b8c725ff3 src/slave/slave.cpp 6a4802338485f8d90220b7f03a99486acae8e2e2 src/tests/master_tests.cpp 8cc8d20fbf44bf9f1bd7e3ab0bc600efbabd2709 src/tests/master_validation_tests.cpp 9efca42d66119dd909e117d239378eca08c5ab82 Diff: https://reviews.apache.org/r/72297/diff/3/ Changes: https://reviews.apache.org/r/72297/diff/2-3/ Testing ------- `make check` Thanks, Greg Mann --===============2938695116544504753==--