From reviews-return-91527-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 3 02:13:23 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 3813F19074 for ; Fri, 3 Apr 2020 02:13:23 +0000 (UTC) Received: (qmail 21599 invoked by uid 500); 3 Apr 2020 02:13:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 21566 invoked by uid 500); 3 Apr 2020 02:13:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 21550 invoked by uid 99); 3 Apr 2020 02:13:22 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2020 02:13:22 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65F1BE069E; Fri, 3 Apr 2020 02:13:21 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 31EBDC40224; Fri, 3 Apr 2020 02:13:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5632234706453822261==" MIME-Version: 1.0 Subject: Re: Review Request 72305: Sent appropriate task status reason when task over memory request. From: Qian Zhang To: Qian Zhang Cc: Greg Mann , mesos Date: Fri, 03 Apr 2020 02:13:20 -0000 Message-ID: <20200403021320.47045.71173@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72305/ X-Sender: Qian Zhang X-ReviewBoard-ShipIt: 1 References: <20200403015942.47044.3708@reviews-vm2.apache.org> In-Reply-To: <20200403015942.47044.3708@reviews-vm2.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============5632234706453822261== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72305/#review220203 ----------------------------------------------------------- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp Lines 717 (patched) I do not think we need this. src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp Lines 719-720 (patched) Why do we use different ways to compare `usage` v.s. `softLimit` and `usage` v.s. `limit`? Can we use the same way? - Qian Zhang On April 3, 2020, 9:59 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72305/ > ----------------------------------------------------------- > > (Updated April 3, 2020, 9:59 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > When a container is OOM-killed and its memory usage is over its > soft memory limit but below its hard memory limit, then we send > schedulers REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED to indicate > that the scheduler's task was preferentially OOM-killed because > it had exceeded its memory request. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 723d85a8656e61f77ab99e5e63f844ec95303ff0 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 15f87ba8c0a1b44fb3380beb0e739af566ab08fc > > > Diff: https://reviews.apache.org/r/72305/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > > --===============5632234706453822261==--