From reviews-return-91509-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 2 03:33:18 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id C428719BA0 for ; Thu, 2 Apr 2020 03:33:17 +0000 (UTC) Received: (qmail 87553 invoked by uid 500); 2 Apr 2020 03:33:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 87505 invoked by uid 500); 2 Apr 2020 03:33:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87490 invoked by uid 99); 2 Apr 2020 03:33:16 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2020 03:33:16 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 74CBAE05CD; Thu, 2 Apr 2020 03:33:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 41E61C40224; Thu, 2 Apr 2020 03:33:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8900125435123534376==" MIME-Version: 1.0 Subject: Review Request 72305: Sent appropriate task status reason when task over memory request. From: Greg Mann To: Qian Zhang Cc: Greg Mann , mesos Date: Thu, 02 Apr 2020 03:33:15 -0000 Message-ID: <20200402033315.58507.21727@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72305/ X-Sender: Greg Mann Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============8900125435123534376== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72305/ ----------------------------------------------------------- Review request for mesos and Qian Zhang. Repository: mesos Description ------- When a container is OOM-killed and its memory usage is over its soft memory limit but below its hard memory limit, then we send schedulers REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED to indicate that the scheduler's task was preferentially OOM-killed because it had exceeded its memory request. Diffs ----- src/common/protobuf_utils.cpp 723d85a8656e61f77ab99e5e63f844ec95303ff0 src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 15f87ba8c0a1b44fb3380beb0e739af566ab08fc Diff: https://reviews.apache.org/r/72305/diff/1/ Testing ------- `make check` Thanks, Greg Mann --===============8900125435123534376==--