From reviews-return-91508-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 2 03:06:48 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 330BE19AA4 for ; Thu, 2 Apr 2020 03:06:48 +0000 (UTC) Received: (qmail 31516 invoked by uid 500); 2 Apr 2020 03:06:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31420 invoked by uid 500); 2 Apr 2020 03:06:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31387 invoked by uid 99); 2 Apr 2020 03:06:41 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2020 03:06:41 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 63876E05CD; Thu, 2 Apr 2020 03:06:41 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3137BC40224; Thu, 2 Apr 2020 03:06:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1266158178579942945==" MIME-Version: 1.0 Subject: Re: Review Request 72297: Added agent-side validation for resource limits. From: Mesos Reviewbot To: Qian Zhang , Benjamin Mahler Cc: Mesos Reviewbot , Greg Mann , mesos Date: Thu, 02 Apr 2020 03:06:40 -0000 Message-ID: <20200402030640.58506.67831@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72297/ X-Sender: Mesos Reviewbot References: <20200402004003.58507.74149@reviews-vm2.apache.org> In-Reply-To: <20200402004003.58507.74149@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============1266158178579942945== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72297/#review220179 ----------------------------------------------------------- Patch looks great! Reviews applied: [72297] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On April 2, 2020, 12:40 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72297/ > ----------------------------------------------------------- > > (Updated April 2, 2020, 12:40 a.m.) > > > Review request for mesos, Benjamin Mahler and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > This prevents tasks from being launched on agents which would > not be capable of enforcing the specified limits. > > > Diffs > ----- > > src/slave/slave.hpp d7e65e0538caa850b1a5bae837e7c06b8c725ff3 > src/slave/slave.cpp 6a4802338485f8d90220b7f03a99486acae8e2e2 > src/tests/master_tests.cpp 8cc8d20fbf44bf9f1bd7e3ab0bc600efbabd2709 > src/tests/master_validation_tests.cpp 9efca42d66119dd909e117d239378eca08c5ab82 > > > Diff: https://reviews.apache.org/r/72297/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > > --===============1266158178579942945==--