From reviews-return-91503-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Apr 1 23:55:26 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 744A71946E for ; Wed, 1 Apr 2020 23:55:25 +0000 (UTC) Received: (qmail 55525 invoked by uid 500); 1 Apr 2020 23:55:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 55488 invoked by uid 500); 1 Apr 2020 23:55:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 55415 invoked by uid 99); 1 Apr 2020 23:55:24 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Apr 2020 23:55:24 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E2B6EE05CD; Wed, 1 Apr 2020 23:55:23 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6FE5EC40224; Wed, 1 Apr 2020 23:55:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1062466652122837861==" MIME-Version: 1.0 Subject: Review Request 72303: Moved documentation into os/exec.hpp interface. From: Benjamin Mahler To: Andrei Sekretenko , Greg Mann Cc: Benjamin Mahler , mesos Date: Wed, 01 Apr 2020 23:55:23 -0000 Message-ID: <20200401235523.58507.23060@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72303/ X-Sender: Benjamin Mahler X-ReviewBoard-Diff-For: 3rdparty/stout/include/stout/os/exec.hpp X-ReviewBoard-Diff-For: 3rdparty/stout/include/stout/os/posix/exec.hpp X-ReviewBoard-Diff-For: 3rdparty/stout/include/stout/os/windows/exec.hpp Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============1062466652122837861== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72303/ ----------------------------------------------------------- Review request for mesos, Andrei Sekretenko and Greg Mann. Repository: mesos Description ------- The os/exec.hpp wrapper provides a single place to read the interface and documentation for both POSIX and Windows, this makes it easier for us to document the interface and OS differences that a caller needs to know about in one place. Diffs ----- 3rdparty/stout/include/stout/os/exec.hpp PRE-CREATION 3rdparty/stout/include/stout/os/posix/exec.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/exec.hpp PRE-CREATION Diff: https://reviews.apache.org/r/72303/diff/1/ Testing ------- make check Thanks, Benjamin Mahler --===============1062466652122837861==--