From reviews-return-91602-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Apr 12 18:29:11 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id D604619421 for ; Sun, 12 Apr 2020 18:29:08 +0000 (UTC) Received: (qmail 12287 invoked by uid 500); 12 Apr 2020 18:29:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 12272 invoked by uid 500); 12 Apr 2020 18:29:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 12256 invoked by uid 99); 12 Apr 2020 18:29:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Apr 2020 18:29:08 +0000 From: GitBox To: reviews@mesos.apache.org Subject: [GitHub] [mesos] cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. Message-ID: <158671614790.5876.3179297244598329140.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 12 Apr 2020 18:29:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r407235607 ########## File path: src/linux/cgroups.cpp ########## @@ -691,21 +760,6 @@ Try create( } -Try remove(const string& hierarchy, const string& cgroup) Review comment: > Let's remove the declaration from the header file too Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services