From reviews-return-91595-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Apr 12 08:11:02 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id B0BEE19FDA for ; Sun, 12 Apr 2020 08:11:00 +0000 (UTC) Received: (qmail 60687 invoked by uid 500); 12 Apr 2020 08:11:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 60668 invoked by uid 500); 12 Apr 2020 08:11:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 60656 invoked by uid 99); 12 Apr 2020 08:11:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Apr 2020 08:11:00 +0000 From: GitBox To: reviews@mesos.apache.org Subject: [GitHub] [mesos] cf-natali commented on issue #355: Handle EBUSY when destroying a cgroup. Message-ID: <158667905997.21765.14292565841773955730.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 12 Apr 2020 08:10:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cf-natali commented on issue #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#issuecomment-612580001 > > > It seems the existing method `cgroups::remove` is not used anywhere except in the unit test codes, so do we still need it? Or we want to change it to internally call the `internal::remove` introduced in this PR? > > > > > > Whatever you prefer :). > > Second thought, it seems not a good idea to make `cgroups::remove` internally call `internal::remove` since they have different return types, so let just leave it as it is. Ah, for some reason I didn't see this edit, so I removed `cgroups::remove` - seems it makes sense since it's not used apart from tests, and we probably don't want to use it since it doesn't have the workaround? It's easy to add back if you want, just let me know what you prefer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services