mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] cf-natali opened a new pull request #359: Made the cgroup listener stop logging spurious error on finalization.
Date Sat, 18 Apr 2020 13:19:46 GMT
cf-natali opened a new pull request #359: Made the cgroup listener stop logging spurious error
on finalization.
URL: https://github.com/apache/mesos/pull/359
 
 
   Before, running any task would cause the following error to be logged
   when the OOM listener was finalized:
   
   ```
   E0418 14:13:25.575969 31596 memory.cpp:637] Listening on OOM events failed for container
65e9cbb5-2e29-4cac-bc98-2723a359a652: Event listener is terminating                      
                                                                                         
 
   ```
   
   The error originates in the OOM listener finalization: https://github.com/apache/mesos/blob/master/src/linux/cgroups.cpp#L1170
   
   Logging an error might make sense, but maybe not if the future was discarded, which the
memory subsystem does upon cleanup: https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp#L586
   
   This removes a lot of noise from the logs, which also makes debugging a bit easier by avoid
following red-herrings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message