mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72303: Moved documentation into os/exec.hpp interface.
Date Thu, 30 Apr 2020 20:11:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72303/
-----------------------------------------------------------

(Updated April 30, 2020, 8:11 p.m.)


Review request for mesos, Andrei Sekretenko and Greg Mann.


Changes
-------

* Pulled out os::execlp removal.


Repository: mesos


Description
-------

The os/exec.hpp wrapper provides a single place to read the interface
and documentation for both POSIX and Windows, this makes it easier
for us to document the interface and OS differences that a caller
needs to know about in one place.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/exec.hpp 4ad130b1b86102b3dc64721247a5fcc6efb5ee7e 
  3rdparty/stout/include/stout/os/posix/exec.hpp db57130470e1e50baebc5e940491a47ef3dd3d98

  3rdparty/stout/include/stout/os/windows/exec.hpp 89db8af637dc6634c541a39a205d16d111e76953



Diff: https://reviews.apache.org/r/72303/diff/4/

Changes: https://reviews.apache.org/r/72303/diff/3-4/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message