-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72401/
-----------------------------------------------------------
(Updated April 29, 2020, 8:07 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comments.
Bugs: MESOS-8877
https://issues.apache.org/jira/browse/MESOS-8877
Repository: mesos
Description (updated)
-------
For command task, its resources will be set when it is launched as a Docker
container by Docker executor, and we do not need to update its resources
afterward since we do not support task resizing. But for the case that a
custom executor launched as a Docker container by Docker containerizer, we
need to update its resources when it launches a new task or an existing task
terminates.
Diffs (updated)
-----
src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d
src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
src/tests/containerizer/docker_containerizer_tests.cpp b069f518d51225c39f0cd5126c02fa08674566ab
Diff: https://reviews.apache.org/r/72401/diff/3/
Changes: https://reviews.apache.org/r/72401/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
|