-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72402/#review220530
-----------------------------------------------------------
src/slave/containerizer/docker.cpp
Lines 2077-2099 (patched)
<https://reviews.apache.org/r/72402/#comment309013>
What do you think about moving this logic into the conditionals below where `totalCPUs`
and `totalMem` are used?
src/slave/containerizer/docker.cpp
Lines 2164-2167 (patched)
<https://reviews.apache.org/r/72402/#comment309014>
Should we have an `#else` case here which does not check the value of `cgroups_enable_cfs`?
src/slave/containerizer/docker.cpp
Line 2095 (original), 2179-2181 (patched)
<https://reviews.apache.org/r/72402/#comment309015>
Why don't we set the soft limit in this case?
- Greg Mann
On April 25, 2020, 10:55 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72402/
> -----------------------------------------------------------
>
> (Updated April 25, 2020, 10:55 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10117
> https://issues.apache.org/jira/browse/MESOS-10117
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated Docker containerizer's `usage()` to support resource limits.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70
> src/tests/containerizer/docker_containerizer_tests.cpp b069f518d51225c39f0cd5126c02fa08674566ab
>
>
> Diff: https://reviews.apache.org/r/72402/diff/5/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
|