mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Date Tue, 28 Apr 2020 19:01:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72399/#review220528
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Lines 2460-2463 (original), 2459-2465 (patched)
<https://reviews.apache.org/r/72399/#comment309008>

    Instead of having both the `containerConfig` argument as well as `resourceRequests`/`resourceLimits`,
couldn't we get rid of `containerConfig` and use a conditional check for `if (containerId.has_parent())`
in `usage()` to control whether we get the request/limit values from the `ContainerConfig`
or from the `Container` struct?



src/slave/containerizer/mesos/containerizer.cpp
Lines 2481-2486 (original), 2483-2508 (patched)
<https://reviews.apache.org/r/72399/#comment309009>

    Can we move this logic into the conditionals for `if (cpuLimit.isSome())` and `if (memLimit.isSome())`
below?



src/slave/containerizer/mesos/containerizer.cpp
Lines 2517 (patched)
<https://reviews.apache.org/r/72399/#comment309010>

    Nit: make `resources` a const ref?



src/slave/containerizer/mesos/containerizer.cpp
Lines 2533-2538 (patched)
<https://reviews.apache.org/r/72399/#comment309011>

    Do you want to move this `foreach` loop out of the conditional, since it's shared by both
branches?



src/slave/containerizer/mesos/containerizer.cpp
Lines 2517-2519 (original), 2589-2594 (patched)
<https://reviews.apache.org/r/72399/#comment309007>

    This stuff looks stale to me, do you think we can remove it?


- Greg Mann


On April 25, 2020, 10:55 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72399/
> -----------------------------------------------------------
> 
> (Updated April 25, 2020, 10:55 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
>     https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated UCR's `usage()` method to support resource limits.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 2ea033aa1869f07644b10c036fda1698d08aa89b

>   src/slave/containerizer/mesos/containerizer.cpp 6aa4f3fe0940575aeea6a63cdb1ca3c77cd2359b

>   src/tests/slave_recovery_tests.cpp 0efd3a6ac09ad06d9365b7bb2295157b5175e6b8 
>   src/tests/slave_tests.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db 
> 
> 
> Diff: https://reviews.apache.org/r/72399/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message