-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72352/#review220491
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On April 24, 2020, 7:14 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72352/
> -----------------------------------------------------------
>
> (Updated April 24, 2020, 7:14 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-10114
> https://issues.apache.org/jira/browse/MESOS-10114
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The accept loop was chaining the loop body Future on the result of
> io::poll/io::read, which meant that any failed poll/read would cause
> the loop body to return a failed future and the loop to stop running.
>
> This would lead to the server socket silently no longer accepting
> incoming connections.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/openssl_socket.hpp 0528c03faaa5f8372cf09c1f51be66934f405661
> 3rdparty/libprocess/src/ssl/openssl_socket.cpp 3f4dab6b92f202ee89cc2e06db997c41e4c6ca00
>
>
> Diff: https://reviews.apache.org/r/72352/diff/2/
>
>
> Testing
> -------
>
> Added a test in subsequent patch.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
|