mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72352: Fixed a bug where OpenSSLSocketImpl accept loop can silently stop.
Date Fri, 24 Apr 2020 19:14:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72352/
-----------------------------------------------------------

(Updated April 24, 2020, 7:14 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

* Used .onReady instead of .then


Bugs: MESOS-10114
    https://issues.apache.org/jira/browse/MESOS-10114


Repository: mesos


Description
-------

The accept loop was chaining the loop body Future on the result of
io::poll/io::read, which meant that any failed poll/read would cause
the loop body to return a failed future and the loop to stop running.

This would lead to the server socket silently no longer accepting
incoming connections.


Diffs (updated)
-----

  3rdparty/libprocess/src/ssl/openssl_socket.hpp 0528c03faaa5f8372cf09c1f51be66934f405661

  3rdparty/libprocess/src/ssl/openssl_socket.cpp 3f4dab6b92f202ee89cc2e06db997c41e4c6ca00



Diff: https://reviews.apache.org/r/72352/diff/2/

Changes: https://reviews.apache.org/r/72352/diff/1-2/


Testing
-------

Added a test in subsequent patch.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message