mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72398: Added `cpus_soft_limit` field to `ResourceStatistics` protobuf message.
Date Fri, 24 Apr 2020 12:40:06 GMT


> On April 24, 2020, 5:19 a.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 1787 (patched)
> > <https://reviews.apache.org/r/72398/diff/1/?file=2224242#file2224242line1787>
> >
> >     This looks like a breaking change, I don't think we should change the type of
existing fields. Why do we need to change this?
> 
> Qian Zhang wrote:
>     The reason that I changed it to double is we need to support infinite limit. As per
https://en.cppreference.com/w/cpp/types/numeric_limits/has_infinity , integer types do support
infinity, so I have to choose to use double.

I have changed it back to `uint64` and set container's hard memory limit to host total memory
if the memory limit specified by framework is infinity in the subsequent patches.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72398/#review220471
-----------------------------------------------------------


On April 24, 2020, 8:24 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72398/
> -----------------------------------------------------------
> 
> (Updated April 24, 2020, 8:24 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10117
>     https://issues.apache.org/jira/browse/MESOS-10117
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `cpus_soft_limit` field to `ResourceStatistics` protobuf message.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9412ed736231547b22abc89188316b08d5445e78 
>   include/mesos/v1/mesos.proto 194c42cf57e34d803a21cab03db17614855e8692 
> 
> 
> Diff: https://reviews.apache.org/r/72398/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message