mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72406: Fixed a bug where the openssl socket can block forever.
Date Thu, 23 Apr 2020 07:58:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72406/#review220450
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On April 21, 2020, 5:43 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72406/
> -----------------------------------------------------------
> 
> (Updated April 21, 2020, 5:43 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-10124
>     https://issues.apache.org/jira/browse/MESOS-10124
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using the zero byte read trick against io::read is problematic
> since io::read aims to provide consistent behavior across POSIX
> and Windows by returning immediately.
> 
> Now that io::poll for reads is implemented, we can fix this by
> removing the Windows specialization and just using io::poll.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/ssl/openssl_socket.cpp 3f4dab6b92f202ee89cc2e06db997c41e4c6ca00

> 
> 
> Diff: https://reviews.apache.org/r/72406/diff/1/
> 
> 
> Testing
> -------
> 
> make check and started running it through internal CI
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message