mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 72404: Fixed discard race in libwinio io operations.
Date Tue, 21 Apr 2020 17:43:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72404/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Greg Mann.


Bugs: MESOS-10123
    https://issues.apache.org/jira/browse/MESOS-10123


Repository: mesos


Description
-------

When getting a discard request for an io operation on windows,
a cancellation is requested and when the io operation completes
a check is performed to see if the future had a discard requested.
However, it's possible that the operation completed successfully
or had a failure and we should not be dropping that information
from the caller.

To correctly check whether the cancellation succeded, we need
to check for ERROR_OPERATION_ABORTED.


Diffs
-----

  3rdparty/libprocess/src/windows/libwinio.cpp 85ee7ea3e148ae26f2374918ed7c853a50b3b6c1 


Diff: https://reviews.apache.org/r/72404/diff/1/


Testing
-------

make check and started running it through internal CI


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message