mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72286: Updated mesos for os/exec.hpp addition to stout.
Date Wed, 15 Apr 2020 20:05:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72286/#review220325
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Sekretenko


On March 30, 2020, 8:14 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72286/
> -----------------------------------------------------------
> 
> (Updated March 30, 2020, 8:14 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some of these files were using utilities that are now in os/exec.hpp.
> For files that already include os.hpp, they get os/exec.hpp
> automatically. However, some files still do fine grained includes
> despite including the catch all os.hpp, so we update those files
> accordingly.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.cpp 1216e0840793d47fb7368dcc416377f00cdb22b1 
>   src/linux/fs.cpp 7d057163800a43177acedb3e69270add5e12d77d 
>   src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
122e9ec9d38843de8dcba11b1ae848cb55c4a35b 
>   src/slave/containerizer/mesos/launch.cpp 2405e310191fe69be7993ce45b42811cd09dd3ae 
>   src/tests/containerizer/cgroups_isolator_tests.cpp f4425f0b5fdecdad36fbd993eb75854b6764888b

>   src/tests/containerizer/perf_tests.cpp 915ad18898b6d8ca2159348b1671ce8f5acd6900 
>   src/tests/environment.cpp b9cfe57a8432794a516e69944e57ece289b577f2 
>   src/uri/fetchers/docker.cpp 12562947dc8c1a5eb25775a112ddea286bfa7b4d 
> 
> 
> Diff: https://reviews.apache.org/r/72286/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message