-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72349/#review220313
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On April 10, 2020, 7:30 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72349/
> -----------------------------------------------------------
>
> (Updated April 10, 2020, 7:30 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-10112
> https://issues.apache.org/jira/browse/MESOS-10112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The caller of OpenSSLSocket::accept() cannot see who tried to
> connect when accept fails, since the accepted socket is not returned.
> This adds logging of the peer address when the SSL handshake fails,
> in order to improve debugging.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/ssl/openssl_socket.cpp a2ec0a3c0178409980ccfad46019340ba8085e3d
>
>
> Diff: https://reviews.apache.org/r/72349/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
|