mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 72349: Added logging of peer address in OpenSSLSocket accept failures.
Date Fri, 10 Apr 2020 19:30:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72349/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Bugs: MESOS-10112
    https://issues.apache.org/jira/browse/MESOS-10112


Repository: mesos


Description
-------

The caller of OpenSSLSocket::accept() cannot see who tried to
connect when accept fails, since the accepted socket is not returned.
This adds logging of the peer address when the SSL handshake fails,
in order to improve debugging.


Diffs
-----

  3rdparty/libprocess/src/ssl/openssl_socket.cpp a2ec0a3c0178409980ccfad46019340ba8085e3d



Diff: https://reviews.apache.org/r/72349/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message