mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 72348: Added logging of peer address in LibeventSSLSocket accept failures.
Date Fri, 10 Apr 2020 19:30:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72348/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Bugs: MESOS-10112
    https://issues.apache.org/jira/browse/MESOS-10112


Repository: mesos


Description
-------

The caller of LibeventSSLSocket::accept() cannot see who tried to
connect when accept fails, since the accepted socket is not returned.
This adds logging of the peer address when the SSL handshake fails,
in order to improve debugging.


Diffs
-----

  3rdparty/libprocess/include/process/address.hpp f23e653aa276e4806a88d8b54f84375ccbaad006

  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp 7bcc66fb3501d6c120bc13d2fd85bd98dbb5673a

  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp dcb6d8e6c82005145c853afa9c24a61d7d0f04a9



Diff: https://reviews.apache.org/r/72348/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message