mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72309: Updated CFS tests to avoid checking CPU usage.
Date Tue, 07 Apr 2020 01:24:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72309/#review220233
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On April 7, 2020, 6:15 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72309/
> -----------------------------------------------------------
> 
> (Updated April 7, 2020, 6:15 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This verification is error-prone and leads to flaky test
> failures. It is sufficient to verify that the cgroup values
> are set correctly. We will avoid going so far as to confirm
> that the kernel's scheduler is honoring those values.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp f4425f0b5fdecdad36fbd993eb75854b6764888b

> 
> 
> Diff: https://reviews.apache.org/r/72309/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*CFS*:-*DOCKER*"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message