mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72315: Introduced test for `addSlave()` with maintenance and unknown framework.
Date Mon, 06 Apr 2020 14:13:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72315/
-----------------------------------------------------------

(Updated April 6, 2020, 2:13 p.m.)


Review request for mesos, Andrei Budnik, Benjamin Mahler, and Greg Mann.


Changes
-------

Added a check of inverse offer generation.


Bugs: MESOS-10109
    https://issues.apache.org/jira/browse/MESOS-10109


Repository: mesos


Description
-------

This is a regression test for MESOS-10109. It ensures that allocator
continues to work after adding an agent that has an unavailability
schedule and resources used by a framework not yet known to allocator.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp af99539ac8f90369a93c08e1419259e3ca043213 


Diff: https://reviews.apache.org/r/72315/diff/2/

Changes: https://reviews.apache.org/r/72315/diff/1-2/


Testing
-------

`./bin/mesos-tests.sh --gtest_filter="*AddAgentWithUnknownFrameworkAndMaintenance*" --gtest_break_on_failure
--gtest_repeat=1000`

Verified that test fails without the preceding patch.


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message