mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72314: Skip not yet known framework IDs in `generateInverseOffers()`.
Date Mon, 06 Apr 2020 14:12:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72314/
-----------------------------------------------------------

(Updated April 6, 2020, 2:12 p.m.)


Review request for mesos, Andrei Budnik, Benjamin Mahler, and Greg Mann.


Changes
-------

Expanded comments and fixed indentation.


Bugs: MESOS-10109
    https://issues.apache.org/jira/browse/MESOS-10109


Repository: mesos


Description
-------

This patch fixes MESOS-10109 by making hierarchical allocator, when
it generates inverse offers, skip IDs of frameworks returned by
`Slave::getOfferedOrAllocated()` that have not yet been added
to the allocator via `addFramework()`.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp 96fd6e3a57e2571651e262bf9ec6137bd5c524f4 
  src/master/allocator/mesos/hierarchical.cpp 0df319b6b1475cc3bb46f88e3788846ecf353468 


Diff: https://reviews.apache.org/r/72314/diff/2/

Changes: https://reviews.apache.org/r/72314/diff/1-2/


Testing
-------

`make check` (+ the test from the next patch)


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message