-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72315/#review220216
-----------------------------------------------------------
Ship it!
src/tests/hierarchical_allocator_tests.cpp
Lines 1099-1103 (patched)
<https://reviews.apache.org/r/72315/#comment308533>
Perhaps clarify that we want an allocation cycle to happen and trigger the inverse offer
generation logic in the allocator in order to test for the regression?
I wonder if we should wait instead for an inverse offer from e.g. another agent to make
sure that happens?
- Benjamin Mahler
On April 3, 2020, 12:55 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72315/
> -----------------------------------------------------------
>
> (Updated April 3, 2020, 12:55 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, and Greg Mann.
>
>
> Bugs: MESOS-10109
> https://issues.apache.org/jira/browse/MESOS-10109
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a regression test for MESOS-10109. It ensures that allocator
> continues to work after adding an agent that has an unavailability
> schedule and resources used by a framework not yet known to allocator.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp af99539ac8f90369a93c08e1419259e3ca043213
>
>
> Diff: https://reviews.apache.org/r/72315/diff/1/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="*AddAgentWithUnknownFrameworkAndMaintenance*" --gtest_break_on_failure
--gtest_repeat=1000`
>
> Verified that test fails without the preceding patch.
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
|