-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72305/#review220183
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
Lines 710-711 (patched)
<https://reviews.apache.org/r/72305/#comment308500>
A newline between.
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
Lines 715 (patched)
<https://reviews.apache.org/r/72305/#comment308502>
We already get max memory usage at L671, so I think we should directly use it rather than
getting usage here.
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
Lines 720-721 (patched)
<https://reviews.apache.org/r/72305/#comment308503>
We already get soft limt at L709, why do we want to get soft limit again here?
- Qian Zhang
On April 2, 2020, 11:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72305/
> -----------------------------------------------------------
>
> (Updated April 2, 2020, 11:37 a.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a container is OOM-killed and its memory usage is over its
> soft memory limit but below its hard memory limit, then we send
> schedulers REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED to indicate
> that the scheduler's task was preferentially OOM-killed because
> it had exceeded its memory request.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 723d85a8656e61f77ab99e5e63f844ec95303ff0
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 15f87ba8c0a1b44fb3380beb0e739af566ab08fc
>
>
> Diff: https://reviews.apache.org/r/72305/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
|