mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72297: Added agent-side validation for resource limits.
Date Thu, 02 Apr 2020 02:18:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72297/#review220178
-----------------------------------------------------------




src/slave/slave.cpp
Lines 2381 (patched)
<https://reviews.apache.org/r/72297/#comment308497>

    Should we return right before this line?



src/tests/master_tests.cpp
Line 4334 (original), 4340-4341 (patched)
<https://reviews.apache.org/r/72297/#comment308498>

    A newline between.


- Qian Zhang


On April 2, 2020, 8:40 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72297/
> -----------------------------------------------------------
> 
> (Updated April 2, 2020, 8:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This prevents tasks from being launched on agents which would
> not be capable of enforcing the specified limits.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp d7e65e0538caa850b1a5bae837e7c06b8c725ff3 
>   src/slave/slave.cpp 6a4802338485f8d90220b7f03a99486acae8e2e2 
>   src/tests/master_tests.cpp 8cc8d20fbf44bf9f1bd7e3ab0bc600efbabd2709 
>   src/tests/master_validation_tests.cpp 9efca42d66119dd909e117d239378eca08c5ab82 
> 
> 
> Diff: https://reviews.apache.org/r/72297/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message