mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] abudnik commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.
Date Tue, 14 Apr 2020 13:57:44 GMT
abudnik commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r408157119
 
 

 ##########
 File path: src/tests/containerizer/cgroups_isolator_tests.cpp
 ##########
 @@ -1489,7 +1489,7 @@ TEST_F(CgroupsIsolatorTest, ROOT_CGROUPS_CreateRecursively)
   // We should remove cgroups_root after the slave being started
   // because slave will create cgroups_root dir during startup
   // if it's not present.
-  ASSERT_SOME(cgroups::remove(hierarchy.get(), flags.cgroups_root));
+  ASSERT_SOME(os::rmdir(path::join(hierarchy.get(), flags.cgroups_root)));
 
 Review comment:
   Please, specify a second parameter `recursive = false` here and elsewhere:
   ```c++
   os::rmdir(path::join(hierarchy.get(), flags.cgroups_root), false)
   ```
   
   I'd recommend running tests under `root` before sending a patch:
   ```shell
   cd build
   sudo make check
   # or
   GLOG_v=2 sudo src/mesos-tests --verbose --gtest_repeat=1 --gtest_filter=*
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message