mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] abudnik commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.
Date Sun, 12 Apr 2020 17:48:27 GMT
abudnik commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407230922
 
 

 ##########
 File path: src/linux/cgroups.cpp
 ##########
 @@ -691,21 +760,6 @@ Try<Nothing> create(
 }
 
 
-Try<Nothing> remove(const string& hierarchy, const string& cgroup)
 
 Review comment:
   Let's remove the declaration from the header file too.
   
   Overall, LGTM. I'll run a CI build for this patch and merge it later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message