mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] qianzhangxa commented on issue #355: Handle EBUSY when destroying a cgroup.
Date Sun, 12 Apr 2020 14:57:24 GMT
qianzhangxa commented on issue #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#issuecomment-612629131
 
 
   > > > > It seems the existing method `cgroups::remove` is not used anywhere
except in the unit test codes, so do we still need it? Or we want to change it to internally
call the `internal::remove` introduced in this PR?
   > > > 
   > > > 
   > > > Whatever you prefer :).
   > > 
   > > 
   > > Second thought, it seems not a good idea to make `cgroups::remove` internally
call `internal::remove` since they have different return types, so let just leave it as it
is.
   > 
   > Ah, for some reason I didn't see this edit, so I removed `cgroups::remove` - seems
it makes sense since it's not used apart from tests, and we probably don't want to use it
since it doesn't have the workaround?
   > 
   > It's easy to add back if you want, just let me know what you prefer.
   
   Yeah, I am OK to remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message