mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] bmahler commented on issue #356: libprocess: check protobuf (de)serialisation success.
Date Tue, 07 Apr 2020 02:29:41 GMT
bmahler commented on issue #356: libprocess: check protobuf (de)serialisation success.
URL: https://github.com/apache/mesos/pull/356#issuecomment-610138094
 
 
   Thanks for reporting this Charles! I will take a closer look soon to confirm the error
handling in this patch is correct and complete.
   
   A couple of logistical things in the meanwhile:
   
   1. Would you be able to file a JIRA ticket? If you'd rather not, that's ok, I can file
one for you, as we'll need one for this bug to be referenced and for this to make it into
the CHANGELOG.
   2. Can you extract the contributors.yaml change from this PR? We enforce that commits in
the project do not mix unrelated changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message