From reviews-return-91312-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 12 14:23:37 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 43E9219B5F for ; Thu, 12 Mar 2020 14:23:37 +0000 (UTC) Received: (qmail 86370 invoked by uid 500); 12 Mar 2020 14:23:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86343 invoked by uid 500); 12 Mar 2020 14:23:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86327 invoked by uid 99); 12 Mar 2020 14:23:36 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Mar 2020 14:23:36 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D488DE0102; Thu, 12 Mar 2020 14:23:35 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A308AC4006F; Thu, 12 Mar 2020 14:23:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3619385791364922255==" MIME-Version: 1.0 Subject: Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery. From: Qian Zhang To: Qian Zhang , Greg Mann Cc: Andrei Budnik , mesos Date: Thu, 12 Mar 2020 14:23:35 -0000 Message-ID: <20200312142335.26802.21452@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71966/ X-Sender: Qian Zhang X-ReviewBoard-ShipIt: 1 References: <20200212154722.16963.74340@reviews-vm2.apache.org> In-Reply-To: <20200212154722.16963.74340@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============3619385791364922255== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219922 ----------------------------------------------------------- Ship it! Ship It! - Qian Zhang On Feb. 12, 2020, 11:47 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71966/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2020, 11:47 p.m.) > > > Review request for mesos, Greg Mann and Qian Zhang. > > > Bugs: MESOS-10079 > https://issues.apache.org/jira/browse/MESOS-10079 > > > Repository: mesos > > > Description > ------- > > This patch enables recovery for nested cgroups and implements > the detection of orphaned nested cgroups. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e > > > Diff: https://reviews.apache.org/r/71966/diff/7/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > > --===============3619385791364922255==--