| Qian Zhang |
Re: Review Request 72161: Added patch for RapidJSON. |
Sun, 01 Mar, 01:34 |
| Qian Zhang |
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. |
Sun, 01 Mar, 09:28 |
| Qian Zhang |
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. |
Mon, 02 Mar, 01:56 |
| Qian Zhang |
Re: Review Request 72161: Added patch for RapidJSON. |
Mon, 02 Mar, 06:27 |
| Qian Zhang |
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. |
Mon, 02 Mar, 06:31 |
| Mesos Reviewbot |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Mon, 02 Mar, 08:19 |
| Greg Mann |
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota. |
Mon, 02 Mar, 09:44 |
| Andrei Budnik |
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. |
Mon, 02 Mar, 11:49 |
| Qian Zhang |
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. |
Mon, 02 Mar, 13:23 |
| Qian Zhang |
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. |
Mon, 02 Mar, 13:27 |
| Greg Mann |
Re: Review Request 71944: Set container process's OOM score adjust. |
Mon, 02 Mar, 13:50 |
| Mesos Reviewbot |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Mon, 02 Mar, 14:54 |
| Qian Zhang |
Re: Review Request 71858: Set resource limits when launching executor container. |
Tue, 03 Mar, 07:07 |
| Andrei Sekretenko |
Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows. |
Tue, 03 Mar, 14:04 |
| Qian Zhang |
Re: Review Request 71858: Set resource limits when launching executor container. |
Tue, 03 Mar, 14:26 |
| Qian Zhang |
Re: Review Request 71858: Set resource limits when launching executor container. |
Tue, 03 Mar, 14:36 |
| Qian Zhang |
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit. |
Tue, 03 Mar, 14:50 |
| Benjamin Mahler |
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows. |
Tue, 03 Mar, 15:36 |
| Andrei Sekretenko |
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows. |
Tue, 03 Mar, 17:10 |
| Andrei Sekretenko |
Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal. |
Tue, 03 Mar, 17:14 |
| Mesos Reviewbot |
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows. |
Tue, 03 Mar, 18:04 |
| Benjamin Mahler |
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal. |
Tue, 03 Mar, 18:06 |
| Mesos Reviewbot |
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups. |
Tue, 03 Mar, 19:01 |
| Andrei Sekretenko |
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal. |
Tue, 03 Mar, 20:14 |
| Benjamin Mahler |
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal. |
Tue, 03 Mar, 20:27 |
| Mesos Reviewbot |
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal. |
Tue, 03 Mar, 21:11 |
| Qian Zhang |
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits. |
Wed, 04 Mar, 01:43 |
| Qian Zhang |
Re: Review Request 71858: Set resource limits when launching executor container. |
Wed, 04 Mar, 02:50 |
| Mesos Reviewbot |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Wed, 04 Mar, 03:10 |
| Greg Mann |
Re: Review Request 71858: Set resource limits when launching executor container. |
Wed, 04 Mar, 09:12 |
| Greg Mann |
Re: Review Request 71858: Set resource limits when launching executor container. |
Wed, 04 Mar, 09:26 |
| Andrei Budnik |
Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`. |
Wed, 04 Mar, 10:56 |
| Andrei Budnik |
Review Request 72190: Added a test `LaunchNestedShareCgroups`. |
Wed, 04 Mar, 10:56 |
| Andrei Budnik |
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch. |
Wed, 04 Mar, 11:01 |
| Qian Zhang |
Re: Review Request 71858: Set resource limits when launching executor container. |
Wed, 04 Mar, 13:14 |
| Greg Mann |
Re: Review Request 71858: Set resource limits when launching executor container. |
Wed, 04 Mar, 13:49 |
| Greg Mann |
Re: Review Request 72161: Added patch for RapidJSON. |
Wed, 04 Mar, 13:56 |
| Mesos Reviewbot |
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`. |
Wed, 04 Mar, 13:58 |
| Greg Mann |
Re: Review Request 72161: Added patch for RapidJSON. |
Wed, 04 Mar, 13:59 |
| Greg Mann |
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. |
Wed, 04 Mar, 15:04 |
| Greg Mann |
Re: Review Request 71858: Set resource limits when launching executor container. |
Wed, 04 Mar, 15:54 |
| Andrei Budnik |
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch. |
Wed, 04 Mar, 15:59 |
| Mesos Reviewbot |
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`. |
Wed, 04 Mar, 16:52 |
| Vinod Kone |
Review Request 72196: Removed stale MPI framework. |
Wed, 04 Mar, 20:55 |
| Benjamin Mahler |
Re: Review Request 72196: Removed stale MPI framework. |
Wed, 04 Mar, 21:20 |
| Qian Zhang |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Thu, 05 Mar, 01:02 |
| Mesos Reviewbot |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Thu, 05 Mar, 02:56 |
| Greg Mann |
Re: Review Request 71884: Updated the `update()` method of isolator to handle resource limits. |
Thu, 05 Mar, 11:22 |
| Greg Mann |
Re: Review Request 71885: Updated the `update()` method of subsystem to handle resource limits. |
Thu, 05 Mar, 11:23 |
| Greg Mann |
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit. |
Thu, 05 Mar, 11:30 |
| Greg Mann |
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit. |
Thu, 05 Mar, 11:55 |
| Greg Mann |
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits. |
Thu, 05 Mar, 12:05 |
| Greg Mann |
Re: Review Request 71951: Added resource limits into the `Task` protobuf message. |
Thu, 05 Mar, 12:05 |
| Greg Mann |
Re: Review Request 71952: Set resource limits when updating executor container. |
Thu, 05 Mar, 15:43 |
| Greg Mann |
Re: Review Request 71952: Set resource limits when updating executor container. |
Thu, 05 Mar, 15:44 |
| Greg Mann |
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota. |
Thu, 05 Mar, 15:56 |
| Greg Mann |
Re: Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods. |
Thu, 05 Mar, 15:56 |
| Greg Mann |
Re: Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods. |
Thu, 05 Mar, 15:57 |
| Greg Mann |
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`. |
Thu, 05 Mar, 17:44 |
| Greg Mann |
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`. |
Thu, 05 Mar, 18:25 |
| Benjamin Mahler |
Review Request 72201: Fixed the broken PathTest.Relative on Windows. |
Thu, 05 Mar, 23:11 |
| Benjamin Mahler |
Review Request 72202: Fixed the broken PathTest.PathIteration on windows. |
Thu, 05 Mar, 23:11 |
| Mesos Reviewbot |
Re: Review Request 72202: Fixed the broken PathTest.PathIteration on windows. |
Fri, 06 Mar, 01:19 |
| Qian Zhang |
Re: Review Request 72161: Added patch for RapidJSON. |
Fri, 06 Mar, 01:42 |
| Greg Mann |
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor. |
Fri, 06 Mar, 08:06 |
| Qian Zhang |
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit. |
Fri, 06 Mar, 08:10 |
| Qian Zhang |
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit. |
Fri, 06 Mar, 08:32 |
| Qian Zhang |
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit. |
Fri, 06 Mar, 08:33 |
| Mesos Reviewbot |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Fri, 06 Mar, 10:03 |
| Qian Zhang |
Re: Review Request 72121: Moved cgroup path helpers to `paths.hpp`. |
Fri, 06 Mar, 12:34 |
| Greg Mann |
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CgroupsEnableCFS`. |
Fri, 06 Mar, 12:44 |
| Greg Mann |
Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits. |
Fri, 06 Mar, 12:49 |
| Greg Mann |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Fri, 06 Mar, 12:53 |
| GitBox |
[GitHub] [mesos] wavesoft opened a new pull request #351: Ensure that long CNI labels are short enough |
Fri, 06 Mar, 13:56 |
| Andrei Sekretenko |
Re: Review Request 72201: Fixed the broken PathTest.Relative on Windows. |
Fri, 06 Mar, 15:25 |
| Andrei Sekretenko |
Re: Review Request 72202: Fixed the broken PathTest.PathIteration on windows. |
Fri, 06 Mar, 15:27 |
| Andrei Sekretenko |
Review Request 72208: Ensured that MasterAPITest.ReservationUpdate waits for changes on agent. |
Fri, 06 Mar, 18:41 |
| Benjamin Mahler |
Re: Review Request 72208: Ensured that MasterAPITest.ReservationUpdate waits for changes on agent. |
Fri, 06 Mar, 18:44 |
| Qian Zhang |
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`. |
Sat, 07 Mar, 02:34 |
| Mesos Reviewbot |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Sat, 07 Mar, 04:01 |
| Mesos Reviewbot |
Re: Review Request 72208: Ensured that MasterAPITest.ReservationUpdate waits for changes on agent. |
Sat, 07 Mar, 05:01 |
| Qian Zhang |
Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`. |
Sat, 07 Mar, 09:01 |
| Qian Zhang |
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`. |
Sat, 07 Mar, 09:02 |
| Qian Zhang |
Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`. |
Sat, 07 Mar, 09:04 |
| Qian Zhang |
Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits. |
Sat, 07 Mar, 09:05 |
| Mesos Reviewbot |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Sat, 07 Mar, 10:29 |
| Qian Zhang |
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch. |
Sun, 08 Mar, 14:29 |
| Qian Zhang |
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch. |
Sun, 08 Mar, 14:33 |
| Greg Mann |
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch. |
Mon, 09 Mar, 06:37 |
| Greg Mann |
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch. |
Mon, 09 Mar, 06:37 |
| Greg Mann |
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch. |
Mon, 09 Mar, 06:56 |
| Qian Zhang |
Re: Review Request 71858: Set resource limits when launching executor container. |
Mon, 09 Mar, 14:04 |
| Qian Zhang |
Re: Review Request 71951: Added resource limits into the `Task` protobuf message. |
Mon, 09 Mar, 14:05 |
| Qian Zhang |
Re: Review Request 71952: Set resource limits when updating executor container. |
Mon, 09 Mar, 14:08 |
| Qian Zhang |
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch. |
Mon, 09 Mar, 14:25 |
| Greg Mann |
Review Request 72215: Added resource limits to one overload of 'createTask()' helper. |
Mon, 09 Mar, 15:22 |
| Greg Mann |
Review Request 72216: Added master validation for task resource limits and shared cgroups. |
Mon, 09 Mar, 15:25 |
| Greg Mann |
Review Request 72217: Added tests for resource limit and shared cgroup validation. |
Mon, 09 Mar, 15:26 |
| Mesos Reviewbot |
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API. |
Mon, 09 Mar, 15:30 |
| Mesos Reviewbot |
Re: Review Request 72217: Added tests for resource limit and shared cgroup validation. |
Mon, 09 Mar, 16:59 |