mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.
Date Wed, 25 Mar 2020 21:07:03 GMT


> On March 25, 2020, 7:20 p.m., Benjamin Mahler wrote:
> > docs/scheduler-http-api.md
> > Lines 529-530 (patched)
> > <https://reviews.apache.org/r/72267/diff/1/?file=2215257#file2215257line530>
> >
> >     Is this true?
> >     
> >     https://github.com/apache/mesos/blob/1.9.0/src/master/allocator/mesos/hierarchical.cpp#L765-L766
> >     
> >     ```
> >       suppressRoles(framework, suppressedRoles - oldSuppressedRoles);
> >       reviveRoles(framework, (oldSuppressedRoles - suppressedRoles) & newRoles);
> >     ```
> >     
> >     1. suppress roles that transitioned into supressed
> >     2. revive roles that were transitioned out of supressed
> >     
> >     So, more like "For roles that were transitioned out of suppressed, offer filters
(set by `ACCEPT`/`DECLINE`) will be cleared.
> >     
> >     Right?

Yes, you are right, existing roles that have filters but are not suppressed will not have
the filters cleared. 
Will amend this line.


> On March 25, 2020, 7:20 p.m., Benjamin Mahler wrote:
> > docs/scheduler-http-api.md
> > Lines 534-535 (patched)
> > <https://reviews.apache.org/r/72267/diff/1/?file=2215257#file2215257line535>
> >
> >     Huh? Which fields are being referred to here?

Everything not named above: all the fileds except for `principal`, `user`, `checkpoint`, `roles`/`role`
and, obviously, except of `id`.


There, actually, is a good question: how well tested is update of other fields and what we
can document here?

I tried to dig into the current state a bit. 

First, there are basic tests that resubscription/UPDATE_FRAMEWORK can change all other fields
in `FrameworkInfo` as reported by Master.

Then, I would say, there are three categories of fields:
1) `name`, `hostname`, `webui_url` and `labels`: these are not really used by Mesos, basic
tests seem enough.

2) `failover_timeout` and `offer_filters`: don't see where we test the effects of updating
them, but those effects look more or less trivial.

3) `capabilities` field: changing some of them has non-trivial effects. 
   For example, removing `REVOCABLE_RESOURCES` results in rescinging offered revocable resources;
this particular scenario is tested. 
   At this point I'm not really sure that every non-trivial capability change is well-designed
and covered by tests.

Do you have any suggestions how to better document all this stuff? 
Can we safely say that Mesos supports update of (1)? How about (2)?
What to state about `capabilities` other than `REVOCABLE_RESOURCES`?...


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72267/#review220079
-----------------------------------------------------------


On March 25, 2020, 2:08 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72267/
> -----------------------------------------------------------
> 
> (Updated March 25, 2020, 2:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-9979
>     https://issues.apache.org/jira/browse/MESOS-9979
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added docs for UPDATE_FRAMEWORK call.
> 
> 
> Diffs
> -----
> 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72267/diff/1/
> 
> 
> Testing
> -------
> 
> Checked rendering in Github: https://github.com/asekretenko/mesos/blob/update_framework_doc/docs/scheduler-http-api.md
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message