mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72221: Added agent validation for shared cgroups.
Date Fri, 20 Mar 2020 17:03:44 GMT


> On March 20, 2020, 7:07 a.m., Qian Zhang wrote:
> > src/slave/validation.cpp
> > Lines 492 (patched)
> > <https://reviews.apache.org/r/72221/diff/5/?file=2214289#file2214289line500>
> >
> >     Why do we need this line? To backward compatible with how standalone containers
are launched currently?

Yep this is for backward compatibility, we only want to return an error when the value has
actually been set to 'true', not when it is simply unset.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72221/#review220030
-----------------------------------------------------------


On March 20, 2020, 12:36 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72221/
> -----------------------------------------------------------
> 
> (Updated March 20, 2020, 12:36 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10045
>     https://issues.apache.org/jira/browse/MESOS-10045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent validation for shared cgroups.
> 
> 
> Diffs
> -----
> 
>   src/slave/validation.cpp 99b17c965d4cc522e9106078a9e6f34fae396b8a 
> 
> 
> Diff: https://reviews.apache.org/r/72221/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message