mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Date Thu, 19 Mar 2020 20:56:10 GMT


> On March 19, 2020, 2:40 p.m., Qian Zhang wrote:
> > src/master/validation.cpp
> > Lines 2073-2085 (patched)
> > <https://reviews.apache.org/r/72216/diff/6/?file=2214259#file2214259line2073>
> >
> >     What if the framework launches multiple executors with the same executor ID
on multiple slaves? I think we want to do this validation for the specific slave rather than
across slaves.
> 
> Greg Mann wrote:
>     I'll iterate over tasks in the slave struct instead.

I did this for active tasks, but unfortunately unreachable tasks are held in the `Slaves`
struct. Since that struct is a member of `Master`, it becomes a little annoying to try to
make use of it in this file, so I did not update the loop here over unreachable tasks.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72216/#review220008
-----------------------------------------------------------


On March 19, 2020, 5:53 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72216/
> -----------------------------------------------------------
> 
> (Updated March 19, 2020, 5:53 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10045
>     https://issues.apache.org/jira/browse/MESOS-10045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added master validation for task resource limits and shared cgroups.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 
> 
> 
> Diff: https://reviews.apache.org/r/72216/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message